Ticket #810 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

fix for the uses of socket in registerhttpcallback

Reported by: hys235 Owned by: yemuru
Priority: critical Milestone:
Component: seattlelib Version: 0.1o
Severity: High Keywords: registerhttpcallback
Cc: cemeyer Blocking:
Blocked By:

Description

Now: registerhttpcallback.repy does not check whether the webpage contents are sent completely to the client or not.
Fix: fix is using sendall() function in 'webserver_test2.repy'

Point: Make sure that all data is sent to the client

Attached:
All files are testing case for registerhttpcallback and httpretrieve.
1. without fix for registerhttpcallback.repy
2. with the fix.
3. .jpg file to test. Must be in the same working directory

I attach two files.
'webserver_test1.repy' is original and 'webserver_test2.repy' is the fix. Do diff and find out the difference.

To Yameru:
I have other issues too.
1. Can you make it so that I can specify the httpstatus code? such as 403 Forbidden? in _registerhttpcallback_send_httpresponse(sock, callbackfunc_val). This will make the library more flexible because response won't be 200 OK all the time.

Attachments

webserver_test1.repy Download (83.8 KB) - added by hys235 10 years ago.
webserver_test2.repy Download (81.9 KB) - added by hys235 10 years ago.
street.jpg Download (291.4 KB) - added by hys235 10 years ago.

Change History

Changed 10 years ago by hys235

Changed 10 years ago by hys235

Changed 10 years ago by hys235

Changed 10 years ago by yemuru

  • status changed from new to closed
  • resolution set to fixed

I have resolved this issue commit for new change can be found on commit #r3364.

Note: See TracTickets for help on using tickets.