Ticket #801 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Problems with the web server / web client...

Reported by: cemeyer Owned by: cemeyer
Priority: major Milestone:
Component: - Version: 0.1o
Severity: Medium Keywords:
Cc: Blocking:
Blocked By:

Description (last modified by sjs25) (diff)

See email thread of the same subject. (The data is pretty mangled from email; I'd appreciate if you'd paste or attach the original here, Steven).

Stephen Sievers: I Reran the tests so that they wouldn't have strange line breaks. Here are the results of the client and server seattlelib tests.

Running: ut_seattlelibtests_testxmlrpc_client.py [ FAIL ]


Standard error : (Produced, Expected):
('---\r\nUncaught exception! Following is a full traceback, and a user traceback.\r\nThe user traceback excludes non-user modules. The most recent call is displayed last.\r\n\r\nFull debugging traceback:\r\n "repy.py", line 189, in main\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\virtual_namespace.py", line 116, in evaluate\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\safe.py", line 304, in safe_run\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 3135, in <module>\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 3109, in send_request\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 1163, in httpretrieve_get_string\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 1030, in httpretrieve_open\r\n\r\nUser traceback:\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 3135, in <module>\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 3109, in send_request\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 1163, in httpretrieve_get_string\r\n "ut_seattlelibtests_testxmlrpc_client.py", line 1030, in httpretrieve_open\r\n\r\nException (with class \'.HttpConnectionError?\'): Error: opening a connection failed with given http server, Given:  http://localhost:8000/ [Errno 10061] No connection could be made because the target machine actively refused it\r\n---\r\n', None)


Running: ut_seattlelibtests_testxmlrpc_common.py [ FAIL ]


Standard error : (Produced, Expected):
('---\r\nUncaught exception! Following is a full traceback, and a user traceback.\r\nThe user traceback excludes non-user modules. The most recent call is displayed last.\r\n\r\nFull debugging traceback:\r\n "repy.py", line 189, in main\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\virtual_namespace.py", line 116, in evaluate\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\safe.py", line 304, in safe_run\r\n "ut_seattlelibtests_testxmlrpc_common.py", line 3668, in <module>\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\safe.py", line 174, in fnc\r\n\r\nUser traceback:\r\n "ut_seattlelibtests_testxmlrpc_common.py", line 3668, in <module>\r\n\r\nUnsafe call: (\'import\',)\r\n---\r\n', None)


Running: ut_seattlelibtests_testxmlrpc_server.py [ FAIL ]


Standard error : (Produced, Expected):
('---\r\nUncaught exception! Following is a full traceback, and a user traceback.\r\nThe user traceback excludes non-user modules. The most recent call is displayed last.\r\n\r\nFull debugging traceback:\r\n "repy.py", line 189, in main\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\virtual_namespace.py", line 116, in evaluate\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\testSandbox\\safe.py", line 304, in safe_run\r\n "ut_seattlelibtests_testxmlrpc_server.py", line 3439, in <module>\r\n\r\nUser traceback:\r\n "ut_seattlelibtests_testxmlrpc_server.py", line 3439, in <module>\r\n\r\nException (with type \'exceptions.TypeError?\'): init() got an unexpected keyword argument \'server_port\'\r\n---\r\n', None)


Attachments

ut_seattlelibtests_testxmlrpc_common.py.diff Download (0.6 KB) - added by cemeyer 10 years ago.
Something like this needs to be done to fix this test (I'm not sure that the diff will apply, but a human should be able to make the changes).
ut_seattlelibtests_testxmlrpc_common,server.py.diff Download (1.2 KB) - added by cemeyer 10 years ago.
This patch fixes use of "localhost" in the tests -- on many machines, localhost will resolve to both "127.0.0.1" and "::1", and we don't want to be ambiguous about what we're binding to. So, be explicit in the tests.
ut_seattlelibtests_testxmlrpc_common-2.diff Download (452 bytes) - added by cemeyer 10 years ago.
Update the xmlrpc-common tests to use the newer xmlrpc interface.
ut_seattlelibtests_testxmlrpc_server.diff Download (0.8 KB) - added by cemeyer 10 years ago.
Fix the xmlrpc-server tests to use the correct way of instantiating the xmlrpc-client.

Change History

Changed 10 years ago by sjs25

  • description modified (diff)

Changed 10 years ago by cemeyer

Where can I get the source for these tests from, Stephen?

Changed 10 years ago by cemeyer

Something like this needs to be done to fix this test (I'm not sure that the diff will apply, but a human should be able to make the changes).

Changed 10 years ago by cemeyer

This patch fixes use of "localhost" in the tests -- on many machines, localhost will resolve to both "127.0.0.1" and "::1", and we don't want to be ambiguous about what we're binding to. So, be explicit in the tests.

Changed 10 years ago by cemeyer

Update the xmlrpc-common tests to use the newer xmlrpc interface.

Changed 10 years ago by cemeyer

Fix the xmlrpc-server tests to use the correct way of instantiating the xmlrpc-client.

Changed 10 years ago by cemeyer

Ok, so if you apply those patches in the order given (they may not apply cleanly, but they're super small changes you can figure out), and then update all the tests to the latest version of httpretrieve, both _common and _server tests should start passing. The _client tests used to connect to some xmlrpc test server somewhere, I think, but now randomly try to connect to localhost on port 8000. I don't think they add value over the _common/_server tests, maybe just get rid of them?

Stephen: let me know how this goes. If you have any trouble (the patches are kind of sloppy) let me know. If everything works, we can close this.

Changed 10 years ago by cemeyer

Status?

Changed 10 years ago by sjs25

I'm still getting errors from the changes you made even though I updated my httpretrieve. Here are the results:

Running: ut_seattlelibtests_testxmlrpc_server.py [ FAIL ]


Standard error : (Produced, Expected):
('---\r\nUncaught exception! Following is a full traceback, and a user traceback.\r\nThe user traceback excludes non-user modules. The most recent call is displayed last.\r\n\r\nFull debugging traceback:\r\n "repy.py", line 189, in main\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\temporary\\virtual_namespace.py", line 116, in evaluate\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\temporary\\safe.py", line 310, in safe_run\r\n "ut_seattlelibtests_testxmlrpc_server.py", line 2968, in <module>\r\n "ut_seattlelibtests_testxmlrpc_server.py", line 2929, in send_request\r\n\r\nUser traceback:\r\n "ut_seattlelibtests_testxmlrpc_server.py", line 2968, in <module>\r\n "ut_seattlelibtests_testxmlrpc_server.py", line 2929, in send_request\r\n\r\nException (with type \'exceptions.TypeError?\'): httpretrieve_get_string() got an unexpected keyword argument \'http_post\'\r\n---\r\n', None)


Running: ut_seattlelibtests_testxmlrpc_common.py [ FAIL ]


Standard error : (Produced, Expected):
('---\r\nUncaught exception! Following is a full traceback, and a user traceback.\r\nThe user traceback excludes non-user modules. The most recent call is displayed last.\r\n\r\nFull debugging traceback:\r\n "repy.py", line 189, in main\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\temporary\\virtual_namespace.py", line 116, in evaluate\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\temporary\\safe.py", line 310, in safe_run\r\n "ut_seattlelibtests_testxmlrpc_common.py", line 3196, in <module>\r\n "C:\\Users\\Owner\\Documents\\Research\\seattle\\temporary\\safe.py", line 180, in fnc\r\n\r\nUser traceback:\r\n "ut_seattlelibtests_testxmlrpc_common.py", line 3196, in <module>\r\n\r\nUnsafe call: (\'import\',)\r\n---\r\n', None)


Changed 10 years ago by cemeyer

For the first one, it looks like xmlrpc needs to be updated to the new httpretrieve interface -- I've done this in r3353.

For the second, I can't really tell what's going on -- can you send me a tarball of the most up to date sources you're testing with?

W.r.t. the UnitTest? framework interface, it would be *hugely* helpful if the stack traces were printed without all of the escaping.

Changed 10 years ago by cemeyer

These would be a lot easier for me to fix if you could check them in to SVN (even if they don't pass!), and assign a ticket to me for each category of broken tests (i.e. one for httpretrieve tests, one for xmlrpc tests, etc). We could get these tests running in a few hours. If you like we can use this ticket as a tracking ticket for all the others you can assign to me.

Changed 10 years ago by sjs25

That was the plan. I'm going to attempt to get permission from Justin to do an svn commit at my individual meeting with him this thursday.

Changed 10 years ago by cemeyer

Alright, thanks. If it's ever relevant, please mention that it'd help me (and probably others) fix bugs in the tests to get the unit testing framework in earlier rather than trying to coordinate out-of-SVN development.

Changed 9 years ago by cemeyer

Status update: this is blocking on ut_ inclusion in SVN; fixing bugs by telepathy is difficult.

Changed 9 years ago by cemeyer

Ok, now that utf has hit SVN I'm working on sorting these out.

Changed 9 years ago by cemeyer

  • status changed from new to closed
  • resolution set to fixed

Fixed in r3582.

Note: See TracTickets for help on using tickets.