Ticket #797 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

httpretrieve incorrectly sanity-checks http headers

Reported by: cemeyer Owned by: cemeyer
Priority: major Milestone:
Component: - Version: 0.1o
Severity: Medium Keywords:
Cc: Blocking: #781
Blocked By:


In httpretrieve (r3288), _httpretrieve_parse_clienthttpheader checks that key.capitalize() != key is false. This is wrong; "Content-Type" is one example of a correct header; "Content-Type".capitalize() is "Content-type". Furthermore I can easily imagine wanting to send headers that don't meet this interpretation of capitalization rules.

Change History

Changed 10 years ago by cemeyer

Also, the encoding is wrong; key + ' : ' + val + '\r\n' should be key + ': ' + val + '\r\n'.

Changed 10 years ago by cemeyer

  • status changed from new to closed
  • resolution set to fixed

Fixed in r3289.

Note: See TracTickets for help on using tickets.