Ticket #795 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

downloading empty filenames cause nodemanager internal error

Reported by: jsamuel Owned by: cemeyer
Priority: major Milestone:
Component: node manager Version: 0.1o
Severity: Medium Keywords:
Cc: justinc Blocking:
Blocked By:

Description

Attempting to download a file with an empty name name ('') causes the following to be seen by the client:

Node Manager error 'Internal Error'

And the following ends up in the nodemanager log:

1260814665.76:PID-4213:Traceback (most recent call last):
  File "/home/uw_seattle/seattle_repy/nmrequesthandler.py", line 92, in handle_request
  File "/home/uw_seattle/seattle_repy/nmrequesthandler.py", line 227, in process_API_call
  File "/home/uw_seattle/seattle_repy/nmAPI.py", line 2858, in retrievefilefromvessel
IOError: [Errno 21] Is a directory

The nodemanager already checks for empty files in nmAPI.mix's addfiletovessel, it was probably just an oversight not adding the same check to retrievefilefromvessel and deletefileinvessel.

CC'ing justinc in case it is felt that this empty filename check should move to emulfile.assert_is_allowed_filename to avoid this type of error in general.

Change History

Changed 10 years ago by justinc

I think it should be fixed in the 'is allowed filename' check.

Changed 10 years ago by cemeyer

  • status changed from new to closed
  • resolution set to fixed

Fixed in r3288.

Note: See TracTickets for help on using tickets.