Ticket #605 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

multiple files relying on indirect import of unused sys from emulcomm

Reported by: jsamuel Owned by: jsamuel
Priority: minor Milestone:
Component: multiple components Version: 0.1l
Severity: Medium Keywords:
Cc: Blocking:
Blocked By:

Description

emulcomm.py imports sys but doesn't use it, and multiple other files appear to be relying on having sys in their namespace from emulcomm, which they are getting from using 'from repyportability import *'. This looks like the list of files needing to import sys themselves (grep output cleaned up a little):

justin@ghent:~/workspace/seattle-trunk/trunk$ grep -RF sys. * | grep -v .svn | cut -d':' -f1 | uniq > using-sys.txt
justin@ghent:~/workspace/seattle-trunk/trunk$ for i in `cat using-sys.txt`; do if [ "`grep "import sys" $i`" == "" ]; then echo $i; fi; done

www/geni/control/vessel_operations.mix
www/node_state_transitions/expire_vessels.mix
www/node_state_transitions/dbnode_checker.py
deploymentscripts/verifyfiles.mix
integrationtests/repy_nm_unit_tests/testingserver.py

Change History

Changed 10 years ago by jsamuel

  • status changed from new to closed
  • resolution set to fixed

Fixed in r2600.

Changed 10 years ago by jsamuel

  • component changed from advertise server to multiple components
Note: See TracTickets for help on using tickets.